add embedded scenario for meldemichel#214
Merged
warm-coolguy merged 6 commits intomainfrom Jan 21, 2025
Merged
Conversation
dopenguin
requested changes
Jan 17, 2025
Member
dopenguin
left a comment
dopenguin
left a comment
There was a problem hiding this comment.
Just some minor suggestions
warm-coolguy
force-pushed
the
add-meldemichel-embedded-scenario
branch
from
31efb29 to
b01b43f
Compare
apply suggestion "fix example id" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
apply suggestion "insist upon <noscript>" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Member
Author
Thanks, the id catch was great, that would've sparked quite some confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An embedded scenario has been added to the Meldemichel. This pertains purely to example code and documentation since it was always possible to do this in POLAR, but not explicitly documented for the Meldemichel yet.
Instructions for local reproduction and review
Build the documentation pages and check the generated scenario on desktop/mobile. The links in the API.md will only start working after this PR is merged.